[SDK] Replace SpinLockMutex with std::mutex in the metrics library - #4416
Open
dbarker wants to merge 10 commits into
Open
[SDK] Replace SpinLockMutex with std::mutex in the metrics library#4416dbarker wants to merge 10 commits into
dbarker wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
+ Coverage 83.09% 83.12% +0.03%
==========================================
Files 519 519
Lines 20253 20256 +3
==========================================
+ Hits 16827 16835 +8
+ Misses 3426 3421 -5
🚀 New features to boost your workflow:
|
dbarker
commented
Aug 12, 2026
ThomsonTan
reviewed
Aug 12, 2026
3 tasks
dbarker
added
pr:please-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4317
Part 2 of #4317 to replace SpinLockMutex with std::mutex.
This PR replaces all use of the SpinLockMutex in the metrics sdk. The goal is to improve synchronization consistency across platforms and deployments by relying on the standard mutex.
Changes
SpinLockMutexwithstd::mutexin the metrics storage classes.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes